Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JustAnOrange's Cybersun Clothing options (Plus Loadout Changes for Recruiter and Synthesis) #2789

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Smugman
Copy link
Contributor

@Smugman Smugman commented Jan 23, 2025

About the PR

With permission from @JustAnOrng, ive finished PR#2285
Ive also Updated the Recruiter and Synthesis loadouts to use their new items.
The Recruiter now also gets a Cybersun briefcase, I will likely implement a "false bottomed" version of this briefcase like the Uplink item of the same name from Paradise Station and give them that (to store their evil contracts :D)
The Emagged Uniform printer can now make Syndicate Utility belts and the new uniforms.

Why / Balance

More Fashion mostly
The Interdyne Defib given to the Synth might be too powerful or redundant considering the planned revamp of their Ship.

Technical details

Uncommented recipes added by my previous PR and added one additional recipe.
Implemented Delta-V comments as requested by Deltanedas in the original PR.

I have been unable to test the loadouts for Synth and Recruiter due to being unable to force the events in my Development Server.
Issue Resolved, all changes have been tested.

Media

TestImageOne

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

N/A

Changelog
🆑

  • add: Emagged Uniform Printers can now Print even more Syndicate Uniforms and a new, sleek toolbelt. Sprites by JustAnOrange
  • add: Sci-, Engi- and Lawdrobes have been "accidentally" Stocked with Cybersun Uniforms, locked behind the MNGR Wire.
  • add: Syndicate Recruiters and Synthesis specialists have been given updated Loadouts.

@Smugman Smugman requested review from a team as code owners January 23, 2025 13:48
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi size/M 64-255 lines labels Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

RSI Diff Bot; head commit 0cbe9dd merging into 069dc1e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Clothing/Belt/syndbelt_overlay.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Clothing/OuterClothing/Coats/cybersunovercoat.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cybersuncasual.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cybersunhazard.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cybersunrnd.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_DV/Objects/Storage/Briefcases/briefcase_cybersun.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 0cbe9dd

Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • Correct the namespaces of the sprites (They should be in _DV) and the path of the YAMLs pointing towards them.

  • Indent the JSON files to a four space indentation instead of two, example:

    {
    "version": 1,
    "license": "CC-BY-SA-3.0",
    "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/555fa0ed9f380509156d94131bd8a3f1c1fee1cf, modified by Radezolid for foam sabre",
    "size": {
    "x": 32,
    "y": 32
    },
    "states": [
    {
    "name": "icon"
    },
    {
    "name": "inhand-left",
    "directions": 4
    },
    {
    "name": "inhand-right",
    "directions": 4
    }
    ]
    }

@Smugman Smugman requested a review from Radezolid January 23, 2025 15:49
@Smugman Smugman requested a review from Radezolid January 23, 2025 18:39
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing needed for it to be okay.

@Smugman Smugman requested a review from Radezolid January 23, 2025 22:15
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta wait on direction's input.

@ThataKat
Copy link
Contributor

Direction reviewing, get back to you in a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants