-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding JustAnOrange's Cybersun Clothing options (Plus Loadout Changes for Recruiter and Synthesis) #2789
base: master
Are you sure you want to change the base?
Conversation
…. Added new Clothes to the Syndie Recruiter.
Added the new Untility belt to the emagged Uniprinter Moved the new Uniforms (and briefcase) to the Contraband Inventory of their respective vends.
RSI Diff Bot; head commit 0cbe9dd merging into 069dc1e Resources/Textures/_DV/Clothing/Belt/syndbelt_overlay.rsi
Resources/Textures/_DV/Clothing/OuterClothing/Coats/cybersunovercoat.rsi
Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cybersuncasual.rsi
Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cybersunhazard.rsi
Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cybersunrnd.rsi
Resources/Textures/_DV/Objects/Storage/Briefcases/briefcase_cybersun.rsi
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
-
Correct the namespaces of the sprites (They should be in
_DV
) and the path of the YAMLs pointing towards them. -
Indent the JSON files to a four space indentation instead of two, example:
{ "version": 1, "license": "CC-BY-SA-3.0", "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/555fa0ed9f380509156d94131bd8a3f1c1fee1cf, modified by Radezolid for foam sabre", "size": { "x": 32, "y": 32 }, "states": [ { "name": "icon" }, { "name": "inhand-left", "directions": 4 }, { "name": "inhand-right", "directions": 4 } ] }
Resources/Prototypes/Catalog/VendingMachines/Inventories/scidrobe.yml
Outdated
Show resolved
Hide resolved
…es to _DV instead.
Resources/Textures/_DV/Clothing/Belt/syndbelt_overlay.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_DV/Clothing/OuterClothing/Coats/cybersunovercoat.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cybersuncasual.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cybersuncasual.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cybersunhazard.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cybersunrnd.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/_DV/Objects/Storage/Briefcases/briefcase_cybersun.rsi/meta.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing needed for it to be okay.
Resources/Textures/_DV/Clothing/Uniforms/Jumpsuit/cybersuncasual.rsi/meta.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotta wait on direction's input.
Direction reviewing, get back to you in a day or two. |
About the PR
With permission from @JustAnOrng, ive finished PR#2285
Ive also Updated the Recruiter and Synthesis loadouts to use their new items.
The Recruiter now also gets a Cybersun briefcase, I will likely implement a "false bottomed" version of this briefcase like the Uplink item of the same name from Paradise Station and give them that (to store their evil contracts :D)
The Emagged Uniform printer can now make Syndicate Utility belts and the new uniforms.
Why / Balance
More Fashion mostly
The Interdyne Defib given to the Synth might be too powerful or redundant considering the planned revamp of their Ship.
Technical details
Uncommented recipes added by my previous PR and added one additional recipe.
Implemented Delta-V comments as requested by Deltanedas in the original PR.
I have been unable to test the loadouts for Synth and Recruiter due to being unable to force the events in my Development Server.Issue Resolved, all changes have been tested.
Media
Requirements
Breaking changes
N/A
Changelog
🆑